RFR: 8308396: Fix offset_of conversion warnings in runtime code [v2]

Coleen Phillimore coleenp at openjdk.org
Fri May 19 12:47:03 UTC 2023


On Fri, 19 May 2023 12:34:21 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix s390
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 4313:
> 
>> 4311:   ldr(holder, Address(method, Method::const_offset()));                      // ConstMethod*
>> 4312:   ldr(holder, Address(holder, ConstMethod::constants_offset()));             // ConstantPool*
>> 4313:   ldr(holder, Address(holder, ConstantPool::pool_holder_offset())); // InstanceKlass*
> 
> Nit: Alignment.

Thanks for reviewing!  Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14053#discussion_r1198915009


More information about the hotspot-dev mailing list