RFR: 8308396: Fix offset_of conversion warnings in runtime code [v4]

Coleen Phillimore coleenp at openjdk.org
Fri May 19 15:54:12 UTC 2023


On Fri, 19 May 2023 14:48:22 GMT, Frederic Parain <fparain at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indentation
>
> src/hotspot/cpu/x86/macroAssembler_x86.cpp line 5119:
> 
>> 5117:   movptr(holder, Address(method, Method::const_offset()));                      // ConstMethod*
>> 5118:   movptr(holder, Address(holder, ConstMethod::constants_offset()));             // ConstantPool*
>> 5119:   movptr(holder, Address(holder, ConstantPool::pool_holder_offset())); // InstanceKlass*
> 
> Comment could be aligned with the comment of the line above.

Thanks - I fixed one but not two others that were  no longer aligned.  Now fixed, with these other changes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14053#discussion_r1199114713


More information about the hotspot-dev mailing list