RFR: 8308403: [s390x] separate remaining_cargs from z_abi_160

Martin Doerr mdoerr at openjdk.org
Fri May 19 17:34:50 UTC 2023


On Fri, 19 May 2023 08:27:59 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> This PR split `z_abi_160` into `z_abi_160_base` and `z_abi_160`. `z_abi_160_base` will represent the minimal structure and overflowing args will be taken care by `remaining_cargs` field present in `z_abi_160`.  We're separating this field because it's causing issue in calculating the correct frame size for Vthreads.

I'm ok with it.

src/hotspot/cpu/s390/frame_s390.hpp line 100:

> 98: 
> 99:   // REMARK: z_abi_160_base structure reflect the "minimal" ABI frame
> 100:   // layout. There is an field in the z_abi_160

Should be "a field".

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14055#pullrequestreview-1434828856
PR Review Comment: https://git.openjdk.org/jdk/pull/14055#discussion_r1199209175


More information about the hotspot-dev mailing list