RFR: 8307190: Refactor ref_at methods in Constant Pool [v4]

[Coleen Phillimore]

On Fri, 19 May 2023 20:12:41 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unused imports
>
> test/hotspot/jtreg/compiler/jvmci/compilerToVM/ConstantPoolTestsHelper.java line 113:
> 
>> 111:           case CONSTANT_METHODREF:
>> 112:           case CONSTANT_INTERFACEMETHODREF:
>> 113:               return Bytecodes.INVOKEVIRTUAL;
> 
> It's better to return INVOKEINTERFACE for CONSTANT_METHODREF.

Why?  It seems like it should be

`CONSTANT_METHODREF: should return Bytecodes.INVOKEVIRTUAL;
 CONSTANT_INTERFACEMETHODREF: should return Bytecodes.INVOKEVIRTUAL`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/13872#discussion_r1199470585