RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v30]

Richard Reingruber rrich at openjdk.org
Mon May 22 08:26:01 UTC 2023


On Fri, 19 May 2023 18:47:49 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/CallArranger.java line 158:
>> 
>>> 156:     class StorageCalculator {
>>> 157:         private final boolean forArguments;
>>> 158:         private boolean forVarArgs = false;
>> 
>> Seems to be not used.
>
> I had kept it in case another PPC64 OS would need it, but I guess it's unlikely. So, I just removed it. Could get added back easily if needed.

I see. There are other examples of redundant code that might serve a purpose in the future. I honestly don't like that.
In the case of `forVarArgs` porters can still find it in the aarch64 version :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1200139200


More information about the hotspot-dev mailing list