RFR: 8308403: [s390x] separate remaining_cargs from z_abi_160 [v2]

[Lutz Schmidt]

On Fri, 19 May 2023 19:02:53 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR split `z_abi_160` into `z_abi_160_base` and `z_abi_160`. `z_abi_160_base` will represent the minimal structure and overflowing args will be taken care by `remaining_cargs` field present in `z_abi_160`.  We're separating this field because it's causing issue in calculating the correct frame size for Vthreads.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   suggestion from Martin

I would like to have the comment updated.
Otherwise LGTM.

src/hotspot/cpu/s390/frame_s390.hpp line 106:

> 104:   // long as we do not provide extra infrastructure, one should use
> 105:   // either z_abi_160_size, or _z_abi(remaining_cargs) instead of
> 106:   // sizeof(...).

I would better like a wording like
Therefore, please use `sizeof(z_abi_160_base)` or the `enum` value `z_abi_160_size` to find out the size of the `ABI` structure.

-------------

Changes requested by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14055#pullrequestreview-1436921327
PR Review Comment: https://git.openjdk.org/jdk/pull/14055#discussion_r1200693698