RFR: 8303040: linux PPC64le: Implementation of Foreign Function & Memory API (Preview) [v33]

[Martin Doerr]

On Mon, 22 May 2023 21:22:50 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add comment about Register Save Area.
>
> src/hotspot/cpu/ppc/downcallLinker_ppc.cpp line 162:
> 
>> 160:   assert(_abi._shadow_space_bytes == frame::native_abi_minframe_size, "expected space according to ABI");
>> 161:   // Note: For ABIv2, we only need (_input_registers.length() > 8) ? _input_registers.length() : 0
>> 162:   int register_save_area_slots = MAX2(_input_registers.length(), 8);
> 
> Both specs, ABI V1 and V2, call this "Parameter Save Area" we should use the same name.
> Suggestion:
> 
>   int parameter_save_area_slots = MAX2(_input_registers.length(), 8);

Thanks! Changed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12708#discussion_r1201234986