RFR: 8308252: Refactor line-by-line file reading code [v4]

Ioi Lam iklam at openjdk.org
Tue May 23 03:40:26 UTC 2023


> I extracted the `get_line()` code from `CompileReplay` and put it in a utility class so that it can be used by `ClassListParser` as well. A few notable changes:
> 
> - Simplified the API
> - Changed the buffer size to a size_t
> - Added size overflow and OOM checks
> - Brought over the `fdopen` logic from `ClassListParser` for handling long path names on Windows. (I don't know how valid this is nowadays, but I don't want to drop it in a refactoring PR).

Ioi Lam has updated the pull request incrementally with two additional commits since the last revision:

 - fixed new line
 - @tstuefe and @dholmes-ora comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14025/files
  - new: https://git.openjdk.org/jdk/pull/14025/files/69ef0d71..6530758a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14025&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14025&range=02-03

  Stats: 75 lines in 4 files changed: 41 ins; 14 del; 20 mod
  Patch: https://git.openjdk.org/jdk/pull/14025.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14025/head:pull/14025

PR: https://git.openjdk.org/jdk/pull/14025


More information about the hotspot-dev mailing list