RFR: 8308252: Refactor line-by-line file reading code [v3]

Ioi Lam iklam at openjdk.org
Tue May 23 03:40:27 UTC 2023


On Thu, 18 May 2023 09:28:42 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> > Looks useful. I wonder if the argument file processing logic might benefit from this too?
> 
> We could use this too for platform specific stuff, e.g. code reading /proc in os_linux.cpp. But for this function to be truly useful, allocator must be choosable since RAs don't always work. So a parameter to define allocation would be nice (malloc or RA).

I want to keep this PR simple and my main goal is to have a correct version of the line reading code. We can expand it to other cases, and add lambdas if it makes sense, in follow-on RFEs.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14025#issuecomment-1558460389


More information about the hotspot-dev mailing list