RFR: 8308400: add ForceEarlyReturn support for virtual threads [v2]

Serguei Spitsyn sspitsyn at openjdk.org
Tue May 23 06:46:51 UTC 2023


On Sat, 20 May 2023 16:00:49 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor tweak in libForceEarlyReturnTest.cpp
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 2042:
> 
>> 2040:     return err;
>> 2041:   }
>> 2042:   bool is_virtual = thread_obj != nullptr && thread_obj->is_a(vmClasses::BaseVirtualThread_klass());
> 
> Does it make sense to reduce code duplication by moving these checks from forceearlyreturn and popframe code into a separate method?

Good suggestion. Let me think a little bit. At least a merge with the PopFrame related push is needed first.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14067#discussion_r1201614464


More information about the hotspot-dev mailing list