RFR: 8308252: Refactor line-by-line file reading code [v3]
Ioi Lam
iklam at openjdk.org
Tue May 23 07:06:54 UTC 2023
On Wed, 17 May 2023 22:48:15 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fixed typo in comments
>
> src/hotspot/share/utilities/lineReader.hpp line 48:
>
>> 46: const char* filename() const { return _filename; }
>> 47: char* get_line();
>> 48: void close();
>
> The `close()` doesn't need to be public.
I think it's useful to have a `close()` function that can be called proactively before the LineReader is destroyed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14025#discussion_r1201644804
More information about the hotspot-dev
mailing list