RFR: 8308403: [s390x] separate remaining_cargs from z_abi_160 [v3]
Lutz Schmidt
lucy at openjdk.org
Tue May 23 08:36:07 UTC 2023
On Mon, 22 May 2023 16:24:10 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> This PR split `z_abi_160` into `z_abi_160_base` and `z_abi_160`. `z_abi_160_base` will represent the minimal structure and overflowing args will be taken care by `remaining_cargs` field present in `z_abi_160`. We're separating this field because it's causing issue in calculating the correct frame size for Vthreads.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> suggestion from @RealLucy
LGTM.
Thanks for adapting the comment.
It is believed to be good practice to have the requested changes implemented and approved before issuing the integrate command.
-------------
Marked as reviewed by lucy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14055#pullrequestreview-1438991412
More information about the hotspot-dev
mailing list