RFR: 8303942: os::write should write completely [v10]

Coleen Phillimore coleenp at openjdk.org
Tue May 23 15:16:23 UTC 2023


On Tue, 23 May 2023 12:52:57 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> `os::write` is implemented using loops until the whole bytes are written. All uses of `os::write` in a loop are changed to single call. 
>> Platform dependent versions of the `os::write` are also renamed and moved to private sections accordingly.
>> Wrong uses/interpretations of return values from `os::write` in JFR code are corrected.
>> 
>> ###Test
>> local: hotspot tier1
>> mach5: tiers 1-5
>
> Afshin Zafari has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8303942: os::write should write completely
>  - 8303942: os::write should write completely

This looks good, thanks for adding the comment and Windows handling for >unsigned int bytes.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/13750#pullrequestreview-1439579036


More information about the hotspot-dev mailing list