RFR: JDK-8282797: CompileCommand parsing errors should exit VM
Tobias Holenstein
tholenstein at openjdk.org
Tue May 23 15:50:56 UTC 2023
Currently, errors during compile command parsing just print an error but don't exit the VM. As a result, issues go unnoticed.
With this PR the behavior is changed to exit the VM when an error occurs.
E.g. `java -XX:CompileCommand=compileonly,HashMap:: -version` will exit the VM after a parsing occurred.
CompileCommand: An error occurred during parsing
Error: Could not parse method pattern
Line: 'compileonly,HashMap::'
Usage: '-XX:CompileCommand=<option>,<method pattern>' - to set boolean option to true
Usage: '-XX:CompileCommand=<option>,<method pattern>,<value>'
Use: '-XX:CompileCommand=help' for more information and to list all option.
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.
### Updated Tests
Updated all tests to now expect an error code `1` for wrong `CompileCommand`
-------------
Commit messages:
- update copyright
- fix trailing whitespace
- Update CheckCompileCommandOption.java
- Update PrintIdealPhaseTest.java
- update OptionTest.java: _id is not a valid intrinsics
- update CompilerConfigFileWarning.java
- adjust Scenario.java for failing CompileCommands
- JDK-8282797: CompileCommand parsing errors should exit VM
Changes: https://git.openjdk.org/jdk/pull/13753/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13753&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8282797
Stats: 164 lines in 24 files changed: 46 ins; 7 del; 111 mod
Patch: https://git.openjdk.org/jdk/pull/13753.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/13753/head:pull/13753
PR: https://git.openjdk.org/jdk/pull/13753
More information about the hotspot-dev
mailing list