RFR: 8308503: AArch64: SIGILL when running with -XX:UseBranchProtection=pac-ret on hardware without PAC feature

[Alan Bateman]

On Tue, 23 May 2023 15:07:22 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 466:
>> 
>>> 464:     } else if (Arguments::enable_preview()) {
>>> 465:       // Not currently compatible with continuation freeze/thaw.
>>> 466:       warning("ROP-protection is incompatible with virtual threads preview feature. Disabling ROP-protection.");
>> 
>> Suggestion:
>> 
>>       _rop_protection = false;
>>       warning("ROP-protection is incompatible with virtual threads preview feature. Disabling ROP-protection.");
>
> I presume you didn't intend to change the logic here.

Virtual threads are proposed to be a permanent feature in JDK 21 so I assume predicating this on Arguments:enable_preview check no longer make sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14095#discussion_r1202602599