RFR: JDK-8282797: CompileCommand parsing errors should exit VM [v3]

Tobias Holenstein tholenstein at openjdk.org
Wed May 24 11:05:01 UTC 2023


> Currently, errors during compile command parsing just print an error but don't exit the VM. As a result, issues go unnoticed. 
> 
> With this PR the behavior is changed to exit the VM when an error occurs.
> 
> E.g. `java -XX:CompileCommand=compileonly,HashMap:: -version` will exit the VM after a parsing occurred.  
> 
> CompileCommand: An error occurred during parsing
> Error: Could not parse method pattern
> Line: 'compileonly,HashMap::'
> 
> Usage: '-XX:CompileCommand=<option>,<method pattern>' - to set boolean option to true
> Usage: '-XX:CompileCommand=<option>,<method pattern>,<value>'
> Use:   '-XX:CompileCommand=help' for more information and to list all option.
> 
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> 
> 
> ### Updated Tests
> Updated all tests to now expect an error code `1` for wrong `CompileCommand`

Tobias Holenstein has updated the pull request incrementally with two additional commits since the last revision:

 - Update Scenario.java
 - Update compilerOracle.cpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/13753/files
  - new: https://git.openjdk.org/jdk/pull/13753/files/8aeef24d..bc36e400

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=13753&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=13753&range=01-02

  Stats: 4 lines in 2 files changed: 1 ins; 1 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/13753.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/13753/head:pull/13753

PR: https://git.openjdk.org/jdk/pull/13753


More information about the hotspot-dev mailing list