RFR: 8308252: Refactor line-by-line file reading code [v6]

Ioi Lam iklam at openjdk.org
Wed May 24 23:41:22 UTC 2023


> I extracted the `get_line()` code from `CompileReplay` and put it in a utility class so that it can be used by `ClassListParser` as well. A few notable changes:
> 
> - Simplified the API
> - Changed the buffer size to a size_t
> - Added size overflow and OOM checks
> - Brought over the `fdopen` logic from `ClassListParser` for handling long path names on Windows. (I don't know how valid this is nowadays, but I don't want to drop it in a refactoring PR).

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  try to fix windows build

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/14025/files
  - new: https://git.openjdk.org/jdk/pull/14025/files/b8a0f31e..f4ba6690

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=14025&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=14025&range=04-05

  Stats: 7 lines in 2 files changed: 1 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk/pull/14025.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14025/head:pull/14025

PR: https://git.openjdk.org/jdk/pull/14025


More information about the hotspot-dev mailing list