RFR: 8308997: RISC-V: Sign extend when comparing 32-bit value with zero instead of testing the sign bit [v3]

Dingli Zhang dzhang at openjdk.org
Tue May 30 03:31:32 UTC 2023


On Tue, 30 May 2023 03:09:24 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove some comments
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 1835:
> 
>> 1833: 
>> 1834:     // if src->is_Array() isn't null then return -1
>> 1835:     __ bgez(t0, L_failed);
> 
> Should this be: `__ bgez(lh, L_failed);` ?

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14197#discussion_r1209669418


More information about the hotspot-dev mailing list