RFR: 8309065: Move the logic to determine archive heap location from CDS to G1 GC [v2]

Ioi Lam iklam at openjdk.org
Wed May 31 21:28:08 UTC 2023


On Wed, 31 May 2023 14:49:23 GMT, Ashutosh Mehra <duke at openjdk.org> wrote:

>> This patch is the first step towards having a single set of GC APIs for allocating heap space for the archived objects (See https://bugs.openjdk.org/browse/JDK-8296263).
>> It moves some of the G1 specific logic from CDS to G1 gc without changing the functionality.
>> 
>> Changes that add/update GC APIs for handling archive heap would be introduced in upcoming patches.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused method FileMapInfo::heap_region_mapped_address
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

The changes look good to me. It passed tiers 1-4 in our CI.

-------------

Marked as reviewed by iklam (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14208#pullrequestreview-1454197891


More information about the hotspot-dev mailing list