RFR: 8304939: os::win32::exit_process_or_thread should be marked noreturn [v5]

Wed Nov 1 05:40:06 UTC 2023

On Mon, 30 Oct 2023 07:15:28 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Addressed some of the review comments
>> 
>> Side note: Should the Style Guide only permit noreturn for void methods? It's Undefined Behaviour when applied to something that returns int for instance, such as exit_process_or_thread here (which I had to refactor to void)
>
>> Side note: Should the Style Guide only permit noreturn for void methods? It's Undefined Behaviour when applied to something that returns int for instance, such as exit_process_or_thread here (which I had to refactor to void)
> 
> I think it is implied that attributes should only be used in a way that is valid.

@dholmes-ora @kimbarrett Please see if you are fine with the final set of changes

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16303#issuecomment-1788439437