RFR: 8318982: Improve Exceptions::special_exception [v2]

[Doug Simon]

On Wed, 1 Nov 2023 02:18:38 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add missing ResourceMark
>
> src/hotspot/share/utilities/exceptions.cpp line 85:
> 
>> 83: // Implementation of Exceptions
>> 84: 
>> 85: bool Exceptions::special_exception(JavaThread* thread, const char* file, int line, Handle h_exception, Symbol* h_name, const char* message) {
> 
> So IIUC now we either have a non-null exception and a null symbol and msg; or vice-versa. Can we assert that so someone doesn't mistakenly pass in non-null values for all three.

Sure: https://github.com/openjdk/jdk/pull/16401/commits/7e6c1a63f4c5104cb82b4bad38c9b8910b156127

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16401#discussion_r1378554373