RFR: 8319117: GrowableArray: Allow for custom initializer instead of copy constructor [v8]

Quan Anh Mai qamai at openjdk.org
Wed Nov 1 15:36:06 UTC 2023


On Wed, 1 Nov 2023 13:50:59 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Call dtr and global placement new
>>  - Do not add this
>
> src/hotspot/share/c1/c1_GraphBuilder.cpp line 181:
> 
>> 179:     block->init_stores_to_locals(method()->max_locals());
>> 180:     _bci2block->at_put(cur_bci, block);
>> 181:     _bci2block_successors.at_put_grow(cur_bci, BlockList(), BlockList());
> 
> I don't understand the purpose of this change.  BlockList is copyable and assignable, so the default filler
> should be adequate.  What am I missing?

You can remove this change, the objects will be default constructed in-place in absence of any addition arguments.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16409#discussion_r1378958381


More information about the hotspot-dev mailing list