Integrated: 8318982: Improve Exceptions::special_exception

Doug Simon dnsimon at openjdk.org
Thu Nov 2 17:46:17 UTC 2023


On Fri, 27 Oct 2023 14:03:45 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR consolidates the 2 almost identical versions of `Exceptions::special_exception` into a single method.
> If a special exception is thrown and `-Xlog:exceptions` is enabled, a log message is emitted and it indicates the special handling.
> 
> Here's an example in the output from running `compiler/linkage/LinkageErrors.java` with `-Xlog:exceptions -Xcomp`:
> 
> [0.194s][info][exceptions] Exception <java/lang/IllegalAccessError: class java.lang.module.ModuleDescriptor$1 tried to access private method 'void java.lang.module.ModuleDescriptor$Exports.<init>(java.util.Set, java.lang.String, java.util.Set, boolean)' (java.lang.module.ModuleDescriptor$1 and java.lang.module.ModuleDescriptor$Exports are in module java.base of loader 'bootstrap')> (0x0000000000000000)
> thrown [src/hotspot/share/interpreter/linkResolver.cpp, line 591]
> for thread 0x000000011e18c600
> thread cannot call Java, throwing pre-allocated exception: a 'java/lang/VirtualMachineError'{0x0000000772e06f00}
> 
> 
> The motivation for this change was work on [JDK-8318694](https://bugs.openjdk.org/browse/JDK-8318694) where it's useful to know when exceptions are thrown on a CompilerThread.

This pull request has now been integrated.

Changeset: f875163c
Author:    Doug Simon <dnsimon at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/f875163c5d1961dd306033d866c95fe91728ba37
Stats:     49 lines in 2 files changed: 20 ins; 21 del; 8 mod

8318982: Improve Exceptions::special_exception

Reviewed-by: coleenp, dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/16401


More information about the hotspot-dev mailing list