RFR: 8318218: RISC-V: C2 CompressBits [v2]

Hamlin Li mli at openjdk.org
Fri Nov 3 12:20:08 UTC 2023


On Fri, 3 Nov 2023 01:18:00 GMT, Feilong Jiang <fjiang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove the new vm option, using Matcher::match_rule_supported instead; move code to riscv_v.ad and C2_MacroAssembler
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 1403:
> 
>> 1401: 
>> 1402: public:
>> 1403:   // compress bits, i.e. j.l.Long::compress.
> 
> All `compress_bits` methods are only used for C2, maybe we could move them into `C2_MacroAssembler`.

Yes, it makes sense.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16481#discussion_r1381589405


More information about the hotspot-dev mailing list