RFR: 8319233: AArch64: Build failure with clang due to -Wformat-nonliteral warning

[Hao Sun]

On Sat, 4 Nov 2023 07:17:25 GMT, Joachim Kern <jkern at openjdk.org> wrote:

>> The root cause is that an incorrect variant of function VMError::report_and_die() is used. We should introduce another variadic function, just as macos_aarch64 did before.
>> 
>> GCC toolchain:
>> From [1][2], GCC differs from Clang in flag -Wformat-nonliteral slightly, i.e. GCC may **not** raise a warning if "the format function takes its fromat arguments as a va_list". That's why this issue is not exposed by GCC toolchain before.
>> 
>> Besides, I suppose platforms ppc and risc-v may have the same issue.
>> 
>> [1] https://gcc.gnu.org/onlinedocs/gcc-11.4.0/gcc/Warning-Options.html
>> [2] https://releases.llvm.org/14.0.0/tools/clang/docs/DiagnosticsReference.html
>
> We consumed your PR overnight. The AIX ppc64 based on clang was fine and without regressions.

Thanks a lot for your verification on ppc and risc-v. @JoKern65 and @VladimirKempik.
I also tested JDK build with gcc and clang on linux/aarch64, linux/x86 and macos/aarch64.

Hence, I think this PR is ready to go.
I will integrate it tomorrow if there are no more comments.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/16486#issuecomment-1793922862