RFR: 8318218: RISC-V: C2 CompressBits [v2]

Hamlin Li mli at openjdk.org
Mon Nov 6 08:52:10 UTC 2023


On Mon, 6 Nov 2023 01:24:37 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove the new vm option, using Matcher::match_rule_supported instead; move code to riscv_v.ad and C2_MacroAssembler
>
> src/hotspot/cpu/riscv/riscv.ad line 1897:
> 
>> 1895: 
>> 1896:     case Op_CompressBits:
>> 1897:       return UseRVV && (MaxVectorSize >= 16);
> 
> Isn't it guaranteed that `MaxVectorSize >= 16` if `UseRVV` is true?

After https://github.com/openjdk/jdk/pull/16498, it should be guaranteed `MaxVectorSize >= 16`.
Let me remove this condition after pr #16498 is pushed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16481#discussion_r1382949011


More information about the hotspot-dev mailing list