RFR: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations

Fei Yang fyang at openjdk.org
Mon Nov 6 09:25:14 UTC 2023


On Mon, 6 Nov 2023 08:47:01 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/vm_version_riscv.cpp line 315:
>> 
>>> 313:       warning("RVV does not support vector length less than 16 bytes. Disabling RVV.");
>>> 314:       UseRVV = false;
>>> 315:       FLAG_SET_DEFAULT(MaxVectorSize, 0);
>> 
>> I think setting `UseRVV` to false would be enough in this case. Why bother resetting MaxVectorSize to 0?
>
> This is  trying to be consistent with the code at LINE 295 in this file.
> Or should I also remove L294-296?

I see. Let's keep it for consistency.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16498#discussion_r1382990653


More information about the hotspot-dev mailing list