RFR: 8267532: Try/catch block not optimized as expected [v3]

Jorn Vernee jvernee at openjdk.org
Mon Nov 6 13:15:18 UTC 2023


On Mon, 6 Nov 2023 08:44:27 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Jorn Vernee has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add some assertion to IR test that check for compilation and deoptimization
>
> test/hotspot/jtreg/compiler/c2/TestExHandlerTrap.java line 37:
> 
>> 35:  *   -Xbatch
>> 36:  *   -Xlog:deoptimization=trace
>> 37:  *   -XX:CompileCommand=PrintCompilation,compiler.c2.TestExHandlerTrap::payload
> 
> Should the logging/printing be removed?

I've left it since the output is pretty minimal, and it seems like it might be useful in case the test ever fails in CI?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16416#discussion_r1383310959


More information about the hotspot-dev mailing list