RFR: 8319408: RISC-V: MaxVectorSize is not consistently checked in several situations [v2]

Hamlin Li mli at openjdk.org
Tue Nov 7 09:03:45 UTC 2023


On Mon, 6 Nov 2023 01:21:48 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refine log
>
> src/hotspot/cpu/riscv/vm_version_riscv.cpp line 306:
> 
>> 304:       MaxVectorSize = _initial_vector_length;
>> 305:     } else if (!is_power_of_2(MaxVectorSize)) {
>> 306:       vm_exit_during_initialization(err_msg("Unsupported MaxVectorSize: %d", (int)MaxVectorSize));
> 
> you can add an explanation, like the following:
> Suggestion:
> 
>       vm_exit_during_initialization(err_msg("Unsupported MaxVectorSize: %d, must be a power of 2", (int)MaxVectorSize));

Thanks, I've added the log message.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16498#discussion_r1384582114


More information about the hotspot-dev mailing list