RFR: 8318986: Improve GenericWaitBarrier performance [v3]
Robbin Ehn
rehn at openjdk.org
Tue Nov 7 10:39:32 UTC 2023
On Tue, 7 Nov 2023 09:49:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> src/hotspot/share/utilities/waitBarrier_generic.cpp line 120:
>>
>>> 118: SpinYield sp;
>>> 119: while (Atomic::load_acquire(&_state) < -1) {
>>> 120: sp.wait();
>>
>> A warning once would be helpful that cells might be too few.
>
> Yes, but I am a bit uncomfortable with printing performance warnings from a generic synchronization primitive. At very least because it might intermittently break some tests that check the outputs. So I'd rather avoid adding stuff here.
Ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16404#discussion_r1384714582
More information about the hotspot-dev
mailing list