RFR: 8319117: GrowableArray: Allow for custom initializer instead of copy constructor [v14]

[Leo Korinth]

On Tue, 7 Nov 2023 13:40:53 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Hi, 
>> 
>> When using at_put and at_put_grow you can provide a value which will be supplied to the constructor of each element. In other words, you can intialize each element through a copy constructor.
>> 
>> I suggest that we also provide a function equivalent where the function is provided a pointer to the memory to be initialized. This can be used for `NONCOPYABLE` classes, for example.
>> 
>> This is implemented using a SFINAE pattern because `nullptr` introduces ambiguity if you use static overload.
>> 
>> Currently running tier1-tier4.
>
> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   More descriptive name and uniform argument order

src/hotspot/share/utilities/growableArray.hpp line 437:

> 435:       this->_len = i+1;
> 436:     }
> 437:     ::new (&this->_data[i]) E(elem);

I think this needs to be guarded (there might already be an element at `i`)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16409#discussion_r1385008942