RFR: 8319716: RISC-V: Add SHA-2

Vladimir Kempik vkempik at openjdk.org
Wed Nov 8 19:20:58 UTC 2023


On Wed, 8 Nov 2023 14:47:07 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

> Hi, please consider.
> 
> Main author is @luhenry, I only fixed some minor things and tested it.
> 
> Such as:
> test/hotspot/jtreg/compiler/intrinsics/sha/
> test/jdk/java/security/MessageDigest/
> test/jdk/jdk/security/
> tier1
> 
> And still running some test.

src/hotspot/cpu/riscv/vm_version_riscv.cpp line 169:

> 167:   }
> 168: 
> 169:   if (UseZvknhb && UseZvkb) {

this looks weird, two jdk options needed to enable sha intrinsincs. 
Can we simplify it somehow  for now , like UseRVVCryptoExt ?
Splitting this into UseZvknhb && UseZvkb can be done in future, if it really would be needed one day

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16562#discussion_r1387093990


More information about the hotspot-dev mailing list