RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v5]

Stefan Karlsson stefank at openjdk.org
Thu Nov 9 07:06:00 UTC 2023


On Wed, 8 Nov 2023 21:50:43 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename monitors_iterate
>
> src/hotspot/share/runtime/vmOperations.cpp line 344:
> 
>> 342:   void do_monitor(ObjectMonitor* monitor) override {
>> 343:     // The caller is interested in the owned ObjectMonitors. This does
>> 344:     // not include when owner is set to a stack-lock address in thread.
> 
> The stack-lock part of this comment doesn't agree with
> the header comment for this relocated version of the code.

Good point. I'll remove the comment and add an `assert(monitor->has_owner(), ...)`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16519#discussion_r1387566964


More information about the hotspot-dev mailing list