RFR: 8315559: Delay TempSymbol cleanup to avoid symbol table churn [v7]

[Oli Gillespie]

On Thu, 9 Nov 2023 18:23:20 GMT, Oli Gillespie <ogillespie at openjdk.org> wrote:

>> test/hotspot/gtest/classfile/test_symbolTable.cpp line 37:
>> 
>>> 35:   ThreadInVMfromNative ThreadInVMfromNative(THREAD);
>>> 36:   // Disable the temp symbol cleanup delay queue because it increases refcounts.
>>> 37:   TempNewSymbol::set_cleanup_delay_enabled(false);
>> 
>> So we have additional check for "enabled" flag in hot production code only to make these tests happy? If so, can we "just" drain the delay queue after new_symbol here? Maybe with helper method here in test?
>
> Yes that's true. I can try to avoid it.

I have added a small helper in the latest commit - do you think it's reasonable?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16398#discussion_r1389265383