RFR: 8318757: VM_ThreadDump asserts in interleaved ObjectMonitor::deflate_monitor calls [v9]
Stefan Karlsson
stefank at openjdk.org
Mon Nov 13 09:00:31 UTC 2023
On Mon, 13 Nov 2023 00:39:28 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Do stuff in the synchronized block of the test
>
> test/hotspot/jtreg/runtime/Monitor/ConcurrentDeflation.java line 71:
>
>> 69:
>> 70: static private void createMonitors() {
>> 71: int monitorCount = 0;
>
> I think this needs to be static to prevent it being hoisted out of the sync block. I try not to assume how clever the JIT might be in this area.
I did make it static, but didn't remove the local monitorCount variable. Fixed now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16519#discussion_r1390779521
More information about the hotspot-dev
mailing list