RFR: 8319406: x86: Shorter movptr(reg, imm) for 32-bit immediates [v4]

Aleksey Shipilev shade at openjdk.org
Mon Nov 13 09:30:21 UTC 2023


On Sat, 11 Nov 2023 00:58:03 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Remove the movslq declaration as well
>>  - Merge branch 'master' into JDK-8319406-shorter-movptr-32
>>  - Enlighs
>>  - Remove new imm64 method completely, inline at use
>>  - Easy review feedback
>>  - Merge branch 'master' into JDK-8319406-shorter-movptr-32
>>  - Fix
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 13453:
> 
>> 13451: }
>> 13452: 
>> 13453: void Assembler::movslq(Register dst, int32_t imm32) {
> 
> You can remove the corresponding declaration in the header file.

Right, removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16497#discussion_r1390824263


More information about the hotspot-dev mailing list