RFR: 8319781: RISC-V: Refactor UseRVV related checks
Robbin Ehn
rehn at openjdk.org
Mon Nov 13 12:38:57 UTC 2023
On Thu, 9 Nov 2023 10:30:41 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you review the patch to refactor the code related UseRVV checks?
> Thanks!
>
> There are some code (flag setting/checking) depending on UseRVV's value, these code should be refactored, especially after the change of https://bugs.openjdk.org/browse/JDK-8319408:
> 1. some code needs to get the final UseRVV's value rather than the initial value, e.g. ChaCha20 intrinsic.
> 2. refactored to be more readable.
> 3. also add note to make sure the future code get the final UseRVV value instead of inital value.
Marked as reviewed by rehn (Reviewer).
> > Hey, how is the changes to SpecialEncodeISOArray related ?
>
> This patch is also to respond the comment at [#16481 (comment)](https://github.com/openjdk/jdk/pull/16481#discussion_r1386040152)
Ok, looks good!
-------------
PR Review: https://git.openjdk.org/jdk/pull/16580#pullrequestreview-1727232825
PR Comment: https://git.openjdk.org/jdk/pull/16580#issuecomment-1808086211
More information about the hotspot-dev
mailing list