RFR: 8314220: Configurable InlineCacheBuffer size [v2]

Ekaterina Vergizova evergizova at openjdk.org
Mon Nov 13 14:46:02 UTC 2023


On Fri, 22 Sep 2023 23:49:25 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Ekaterina Vergizova has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Changed type, added range check
>
> src/hotspot/share/runtime/flags/jvmFlagConstraintsCompiler.cpp line 459:
> 
>> 457:   }
>> 458: 
>> 459:   if ((value % CodeEntryAlignment) != 0) {
> 
> I don't understand why this is necessary.

It is needed to avoid 'failed: _buffer_size  not aligned' crashes on debug builds: 
https://github.com/openjdk/jdk/blob/master/src/hotspot/share/code/stubs.cpp#L221

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15271#discussion_r1391205013


More information about the hotspot-dev mailing list