RFR: 8318218: RISC-V: C2 CompressBits [v7]

Hamlin Li mli at openjdk.org
Mon Nov 13 15:06:19 UTC 2023


On Mon, 13 Nov 2023 14:44:44 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine code
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1702:
> 
>> 1700:   vmv_v_i(v8, 0);
>> 1701:   // load the mask data(in bits).
>> 1702:   vsetivli(x0, 1, sew, lmul);
> 
> Please also change line into "vsetivli(x0, 1, sew, Assembler::m1)" for consistency. Otherwise LGTM.

Modified.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16481#discussion_r1391238036


More information about the hotspot-dev mailing list