RFR: 8318218: RISC-V: C2 CompressBits [v8]

[Fei Yang]

On Mon, 13 Nov 2023 15:06:16 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you review the change to add intrinsic for CompressBits for Long & Integer?
>> Thanks!
>> 
>> ## Test
>> pass jtreg test:
>> test/jdk/java/lang/CompressExpand*.java
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refine code 2

Ah ... We still have two copy-paste issues.

src/hotspot/cpu/riscv/riscv_v.ad line 2884:

> 2882: 
> 2883: instruct compressBitsI(iRegINoSp dst, iRegIorL2I src, iRegIorL2I mask, vRegMask_V0 v0,
> 2884:                        vReg_V4 v4, vReg_V4 v5, vReg_V8 v8, vReg_V4 v9) %{

Just noticed that this should be `vReg_V4 v4, vReg_V5 v5, vReg_V8 v8, vReg_V9 v9`.

src/hotspot/cpu/riscv/riscv_v.ad line 2911:

> 2909: instruct compressBitsL(iRegLNoSp dst, iRegL src, iRegL mask, vRegMask_V0 v0,
> 2910:                        vReg_V4 v4, vReg_V4 v5, vReg_V4 v6, vReg_V4 v7,
> 2911:                        vReg_V8 v8, vReg_V4 v9, vReg_V4 v10, vReg_V4 v11) %{

Similar issue here for v5-v7 and v9-v11.

-------------

Changes requested by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16481#pullrequestreview-1727528614
PR Review Comment: https://git.openjdk.org/jdk/pull/16481#discussion_r1391244946
PR Review Comment: https://git.openjdk.org/jdk/pull/16481#discussion_r1391247033