RFR: 8319944: Remove DynamicDumpSharedSpaces [v2]

Calvin Cheung ccheung at openjdk.org
Mon Nov 13 18:01:57 UTC 2023


On Mon, 13 Nov 2023 05:53:14 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Please review this cleanup. Most of the changes are the following patterns:
>> 
>> - `if (DumpSharedSpaces)` => `if (CDSConfig::is_dumping_dynamic_archive())`
>> - `DumpSharedSpaces = true` => `CDSConfig::enable_dumping_dynamic_archive()`
>> - `DumpSharedSpaces = false` => `CDSConfig::disable_dumping_dynamic_archive()`
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed typo

Looks good.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16626#pullrequestreview-1727906921


More information about the hotspot-dev mailing list