RFR: 8319999: Refactor MetaspaceShared::use_full_module_graph() [v2]

[David Holmes]

On Tue, 14 Nov 2023 04:57:14 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> src/hotspot/share/cds/cdsConfig.hpp line 33:
>> 
>>> 31: class CDSConfig : public AllStatic {
>>> 32: #if INCLUDE_CDS
>>> 33:   static bool     _is_dumping_dynamic_archive;
>> 
>> Nit: Extra spaces
>
> The alignment is the same as the is_dumping_xxx()/enable_dumping_xxx() functions below, so it's easier to read the "dumping" and "loading" part of the names.

Sorry that is not a valid reason IMO. It's bad enough when people want the start of names to line up, never-mind the middle of them!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16646#discussion_r1391995395