RFR: 8319999: Refactor MetaspaceShared::use_full_module_graph() [v2]

[David Holmes]

On Tue, 14 Nov 2023 05:29:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> I like the variable name to be the same as the function name, so it's easier to search. We also have `bool _enable_preview;` in arguments.hpp
>
> But the context is different. `enable_xxx()` indicates that the function enables xxx. The variable that holds the enabled/disabled state of xxx should reflect in its name that it holds that state so `_xxx_enabled` Or `_has_xxx`, or `_is_xxx`, depending on what `xxx` actually is.

Or `_use_xxx` as was originally used here. I guess I just find it particularly irksome that `enable` is often used where `enabled` would be the grammatically correct choice.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16646#discussion_r1392008700