RFR: 8319716: RISC-V: Add SHA-2
Fei Yang
fyang at openjdk.org
Tue Nov 14 08:16:29 UTC 2023
On Wed, 8 Nov 2023 14:47:07 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
> Hi, please consider.
>
> Main author is @luhenry, I only fixed some minor things and tested it.
>
> Such as:
> test/hotspot/jtreg/compiler/intrinsics/sha/
> test/jdk/java/security/MessageDigest/
> test/jdk/jdk/security/
> tier1
>
> And still running some test.
src/hotspot/cpu/riscv/vm_version_riscv.cpp line 160:
> 158: }
> 159:
> 160: if (UseZvknha && UseZvkb) {
A simple question here: Does the existence of `Zvknhb` means availability of `Zvknha`? Or should this be something like `if ((UseZvknha || UseZvknhb) && UseZvkb)`?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16562#discussion_r1392153578
More information about the hotspot-dev
mailing list