RFR: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks [v2]

Roman Marchenko rmarchenko at openjdk.org
Tue Nov 14 08:18:43 UTC 2023


On Tue, 14 Nov 2023 07:42:08 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixing review comments
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 217:
> 
>> 215:   // all callbacks initially null
>> 216:   memset(&_event_callbacks,0,sizeof(jvmtiEventCallbacks));
>> 217:   memset(&_ext_event_callbacks, 0, sizeof(jvmtiExtEventCallbacks));
> 
> Looks good.
> 
> While you are here could you adjust the existing memset line and add spaces after the commas please. Thanks.

Done

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16647#discussion_r1392157095


More information about the hotspot-dev mailing list