RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v2]

[Xiaohong Gong]

On Wed, 25 Oct 2023 01:25:09 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 8496:
>> 
>>> 8494:     // Get sleef stub routine addresses
>>> 8495:     char ebuf[1024];
>>> 8496:     void* libsleef = os::dll_load(UseSleefLib, ebuf, sizeof ebuf);
>> 
>> Shouldn't this check that UseSleefLib has been set to something other than "" ? (To save the failing `dll_load` call.)
>
> Yeah, it's better to do that. Currently it returns "nullptr" without any errors. But I agree that having a pre-check is better. Thanks!

`UseSleefLib` is removed in latest commit. So this change is not needed anymore. Thanks for the suggestion all the time!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16234#discussion_r1393523299