RFR: 8318217: RISC-V: C2 VectorizedHashCode [v2]
Hamlin Li
mli at openjdk.org
Wed Nov 15 11:16:30 UTC 2023
On Tue, 14 Nov 2023 15:40:30 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Yuri Gaevsky has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Minor cosmetic fixes.
>
> src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp line 1491:
>
>> 1489: beqz(cnt, DONE);
>> 1490:
>> 1491: ld(pow31_1_2, ExternalAddress(StubRoutines::riscv::arrays_hashcode_powers_of_31()
>
> Does `mv` of the power values to pow31_1_2 do the same effect as the `ld` here? If it does, mv might be better than ld.
Seems not for a 64bit immediate by current cost model of riscv in jdk.
Please ignore this suggestion, and below one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16629#discussion_r1394058586
More information about the hotspot-dev
mailing list