RFR: 8318217: RISC-V: C2 VectorizedHashCode [v2]
Yuri Gaevsky
duke at openjdk.org
Thu Nov 16 09:00:41 UTC 2023
On Tue, 14 Nov 2023 15:43:39 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> Yuri Gaevsky has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Minor cosmetic fixes.
>
> src/hotspot/cpu/riscv/riscv.ad line 10312:
>
>> 10310: match(Set result (VectorizedHashCode (Binary ary cnt) (Binary result basic_type)));
>> 10311: effect(TEMP tmp1, TEMP tmp2, TEMP tmp3, TEMP tmp4, TEMP tmp5, TEMP tmp6,
>> 10312: USE_KILL ary, USE_KILL cnt, USE basic_type, KILL cr);
>
> should `TEMP_DEF result` be added here?
Hmm, addition of TEMP_DEF result makes the bencmark results even worse tha without intrinsic (I haven't look at the generated assembler though).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16629#discussion_r1395361296
More information about the hotspot-dev
mailing list