RFR: 8320147: Remove DumpSharedSpaces

Calvin Cheung ccheung at openjdk.org
Thu Nov 16 23:42:30 UTC 2023


On Thu, 16 Nov 2023 22:36:17 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> One more PR for cleanup with cdsConfig.hpp:
> 
> Replace the global variable `DumpSharedSpaces` with `CDSConfig::is_dumping_static_archive()`.
> 
> Note: some mis-uses of `DumpSharedSpaces` need to be replaced with `CDSConfig::is_dumping_heap()` or `CDSConfig::is_dumping_full_module_graph()`

Few files require copyright header update.

instanceClassLoaderKlass.hpp
instanceMirrorKlass.hpp
instanceRefKlass.hpp
instanceStackChunkKlass.hpp

src/hotspot/share/oops/instanceClassLoaderKlass.cpp line 2:

> 1: /*
> 2:  * Copyright (c) 1997, 2023, Oracle and/or its affiliates. All rights reserved.

Since this is a new file, no need to include 1997.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16700#pullrequestreview-1735730095
PR Review Comment: https://git.openjdk.org/jdk/pull/16700#discussion_r1396496277


More information about the hotspot-dev mailing list