RFR: 8301997: Move method resolution information out of the cpCache [v13]

Matias Saavedra Silva matsaave at openjdk.org
Fri Nov 17 18:59:02 UTC 2023


On Wed, 15 Nov 2023 16:45:09 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   S390 port
>
> I believe this PR has reached a stage where it can be safely committed. Thank you to all the reviewers for your excellent feedback and thank you to all porters for your contributions!

> @matias9927 this broke arm (32-bit) build:
> 
> ```
> /home/runner/work/jdk/jdk/src/hotspot/cpu/arm/interp_masm_arm.cpp:236:17: error: 'ConstantPoolCacheEntry' was not declared in this scope; did you mean 'ConstantPoolCache'?
>   236 |   assert(sizeof(ConstantPoolCacheEntry) == 4*wordSize, "adjust code below");
>       |                 ^~~~~~~~~~~~~~~~~~~~~~
> ```
> 
> I don't see GHA testing is setup for your repo.

This patch includes changes to the interpreters which were provided by porters. Oracle is responsible for x86-64 and aarch64 so completed those and made an effort to inform porters of the upcoming change. The ARM32 port has not yet been completed and thus is not part of this patch.

The ARM32 ports have previously been handled by @bulasevich and @voitylov and they have been contacted.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/15455#issuecomment-1816932564


More information about the hotspot-dev mailing list